From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MD2lq-0000bq-B5
	for qemu-devel@nongnu.org; Sat, 06 Jun 2009 16:45:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MD2ll-0000Wu-LO
	for qemu-devel@nongnu.org; Sat, 06 Jun 2009 16:45:41 -0400
Received: from [199.232.76.173] (port=53565 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MD2ll-0000Wj-H4
	for qemu-devel@nongnu.org; Sat, 06 Jun 2009 16:45:37 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44533)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MD2lk-0003yz-S4
	for qemu-devel@nongnu.org; Sat, 06 Jun 2009 16:45:37 -0400
Date: Sat, 6 Jun 2009 23:44:40 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] virtio-net: Increase filter and
	control limits
Message-ID: <20090606204358.GB26877@redhat.com>
References: <20090605204647.3355.81929.stgit@kvm.aw>
	<20090605204723.3355.1737.stgit@kvm.aw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090605204723.3355.1737.stgit@kvm.aw>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@hp.com>
Cc: qemu-devel@nongnu.org

On Fri, Jun 05, 2009 at 02:47:23PM -0600, Alex Williamson wrote:
> Increase the size of the perfect filter table and control queue depth.
> This should give us more headroom in the MAC filter and is known to be
> needed by at least one guest user.

Just curious - which guest is that?

> Increasing the control queue depth
> allows a guest to feed several commands back to back if they so desire
> rather than using the send and wait approach Linux uses.
> 
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> ---
> 
>  hw/virtio-net.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
> index ecb58de..efaff04 100644
> --- a/hw/virtio-net.c
> +++ b/hw/virtio-net.c
> @@ -18,7 +18,7 @@
>  
>  #define VIRTIO_NET_VM_VERSION    10
>  
> -#define MAC_TABLE_ENTRIES    32
> +#define MAC_TABLE_ENTRIES    64
>  #define MAX_VLAN    (1 << 12)   /* Per 802.1Q definition */
>  
>  typedef struct VirtIONet
> @@ -685,7 +685,7 @@ VirtIODevice *virtio_net_init(DeviceState *dev)
>      n->vdev.reset = virtio_net_reset;
>      n->rx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_rx);
>      n->tx_vq = virtio_add_queue(&n->vdev, 256, virtio_net_handle_tx);
> -    n->ctrl_vq = virtio_add_queue(&n->vdev, 16, virtio_net_handle_ctrl);
> +    n->ctrl_vq = virtio_add_queue(&n->vdev, 64, virtio_net_handle_ctrl);
>      qdev_get_macaddr(dev, n->mac);
>      n->status = VIRTIO_NET_S_LINK_UP;
>      n->vc = qdev_get_vlan_client(dev,
> 
> 

-- 
MST