From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.
Date: Mon, 8 Jun 2009 14:04:27 +0100 [thread overview]
Message-ID: <200906081404.28277.paul@codesourcery.com> (raw)
In-Reply-To: <1244464428-3795-1-git-send-email-kraxel@redhat.com>
> typedef struct {
> + DeviceState qdev;
>...
>+static struct DeviceInfo i440fx_pcihost_devinfo = {
>+ .init = i440fx_initfn,
>+ .bus_type = BUS_TYPE_SYSTEM,
>+};
This is clearly a lie.
> + s = container_of(qdev_create(NULL, "i440FX-pcihost"), I440FXState,
And this should be using FROM_SYSBUS.
Paul
next prev parent reply other threads:[~2009-06-08 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 12:33 [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus Gerd Hoffmann
2009-06-08 13:04 ` Paul Brook [this message]
2009-06-08 14:04 ` Gerd Hoffmann
2009-06-08 14:53 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906081404.28277.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).