From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDeWm-0007wG-C3
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 09:04:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDeWj-0007uq-0O
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 09:04:40 -0400
Received: from [199.232.76.173] (port=41906 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDeWi-0007uh-Ni
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 09:04:36 -0400
Received: from mx20.gnu.org ([199.232.41.8]:55614)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MDeWi-0001Wp-7Z
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 09:04:36 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MDeWf-0000ZK-7S
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 09:04:35 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.
Date: Mon, 8 Jun 2009 14:04:27 +0100
References: <1244464428-3795-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1244464428-3795-1-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906081404.28277.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

> typedef struct {
> +    DeviceState qdev;
>...
>+static struct DeviceInfo i440fx_pcihost_devinfo = {
>+    .init = i440fx_initfn,
>+    .bus_type = BUS_TYPE_SYSTEM,
>+};

This is clearly a lie.

> +    s = container_of(qdev_create(NULL, "i440FX-pcihost"), I440FXState,

And this should be using FROM_SYSBUS.

Paul