From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDtwL-0005sE-4r
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 01:32:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDtwE-0005rn-QA
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 01:32:03 -0400
Received: from [199.232.76.173] (port=38070 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDtwE-0005rk-Ke
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 01:31:58 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54555)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MDtwE-0008HK-2d
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 01:31:58 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n595VvL4029211
	for <qemu-devel@nongnu.org>; Tue, 9 Jun 2009 01:31:57 -0400
Date: Tue, 9 Jun 2009 08:31:54 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] Add pci_bus_reset() function.
Message-ID: <20090609053154.GO27210@redhat.com>
References: <1244465766-6349-1-git-send-email-gleb@redhat.com>
	<1244465766-6349-2-git-send-email-gleb@redhat.com>
	<4A2D219F.1020408@redhat.com> <20090608143710.GM27210@redhat.com>
	<4A2D85B8.1090301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A2D85B8.1090301@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dor Laor <dlaor@redhat.com>
Cc: Yaniv Kamay <ykamay@redhat.com>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Tue, Jun 09, 2009 at 12:42:16AM +0300, Dor Laor wrote:
> Gleb Natapov wrote:
>> On Mon, Jun 08, 2009 at 05:35:11PM +0300, Avi Kivity wrote:
>>   
>>> Gleb Natapov wrote:
>>>     
>>>> To reset internal irq handling data structures.
>>>>
>>>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>>>> Signed-off-by: Yaniv Kamay <ykamay@redhat.com>
>>>> ---
>>>>  hw/pci.c |   16 ++++++++++++++++
>>>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/hw/pci.c b/hw/pci.c
>>>> index 02b335f..89fefdf 100644
>>>> --- a/hw/pci.c
>>>> +++ b/hw/pci.c
>>>> @@ -88,6 +88,21 @@ static int  pcibus_load(QEMUFile *f, void *opaque, int version_id)
>>>>      return 0;
>>>>  }
>>>>  +static void pci_bus_reset(void *opaque)
>>>> +{
>>>> +    PCIBus *bus = (PCIBus *)opaque;
>>>> +    int i;
>>>> +
>>>> +    for (i = 0; i < bus->nirq; i++) {
>>>> +        bus->irq_count[i] = 0;
>>>> +    }
>>>> +    for (i = 0; i < PCI_DEVICES_MAX; i++) {
>>>> +        if (bus->devices[i])
>>>> +            memset(bus->devices[i]->irq_state, 0,
>>>> +                   sizeof(bus->devices[i]->irq_state));
>>>> +    }
>>>> +}
>>>> +
>>>>         
>>> Shouldn't each device's reset function bring its line low, thus 
>>> zeroing  the irq_state naturally?
>>>
>>> If not, we have a bug somewhere.  Note we have exactly the same issue 
>>>  with save/restore.
>>>
>>>     
>> They should, but I haven't found one that does.
>>   
> virtio does and so do many others. Sad thing is that all should do it  
> since the line is shared.
> e1000 and rtl8139 do not register a reset handler.
>
So somebody (not me) should go and fix all others.

> Maybe we should make it a required callback for pci_qdev_register? or better
> have every (pci?) device register several callback together.
May be.

--
			Gleb.