From: Gleb Natapov <gleb@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCHv2] remove unused field from pci device.
Date: Tue, 9 Jun 2009 12:18:31 +0300 [thread overview]
Message-ID: <20090609091831.GT27210@redhat.com> (raw)
Rename pci_irq_index to pci_device_count because this is what it
actually does.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/hw/pci.c b/hw/pci.c
index 0ab5b94..d00041a 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -54,7 +54,7 @@ static void pci_set_irq(void *opaque, int irq_num, int level);
target_phys_addr_t pci_mem_base;
static uint16_t pci_default_sub_vendor_id = PCI_SUBVENDOR_ID_REDHAT_QUMRANET;
static uint16_t pci_default_sub_device_id = PCI_SUBDEVICE_ID_QEMU;
-static int pci_irq_index;
+static int pci_device_count;
static PCIBus *first_bus;
static void pcibus_save(QEMUFile *f, void *opaque)
@@ -245,7 +245,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
PCIConfigReadFunc *config_read,
PCIConfigWriteFunc *config_write)
{
- if (pci_irq_index >= PCI_DEVICES_MAX)
+ if (pci_device_count >= PCI_DEVICES_MAX)
return NULL;
if (devfn < 0) {
@@ -268,7 +268,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
config_write = pci_default_write_config;
pci_dev->config_read = config_read;
pci_dev->config_write = config_write;
- pci_dev->irq_index = pci_irq_index++;
+ pci_device_count++;
bus->devices[devfn] = pci_dev;
pci_dev->irq = qemu_allocate_irqs(pci_set_irq, pci_dev, 4);
return pci_dev;
@@ -322,7 +322,7 @@ int pci_unregister_device(PCIDevice *pci_dev)
pci_unregister_io_regions(pci_dev);
qemu_free_irqs(pci_dev->irq);
- pci_irq_index--;
+ pci_device_count--;
pci_dev->bus->devices[pci_dev->devfn] = NULL;
qdev_free(&pci_dev->qdev);
return 0;
diff --git a/hw/pci.h b/hw/pci.h
index 0405837..fb7b89a 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -154,8 +154,6 @@ struct PCIDevice {
PCIConfigReadFunc *config_read;
PCIConfigWriteFunc *config_write;
PCIUnregisterFunc *unregister;
- /* ??? This is a PC-specific hack, and should be removed. */
- int irq_index;
/* IRQ objects for the INTA-INTD pins. */
qemu_irq *irq;
--
Gleb.
next reply other threads:[~2009-06-09 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 9:18 Gleb Natapov [this message]
2009-06-09 13:01 ` [Qemu-devel] [PATCHv2] remove unused field from pci device Paul Brook
2009-06-09 13:03 ` Gleb Natapov
2009-06-09 13:11 ` Paul Brook
2009-06-09 13:22 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609091831.GT27210@redhat.com \
--to=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).