From: Gleb Natapov <gleb@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] remove unused field from pci device.
Date: Tue, 9 Jun 2009 16:22:28 +0300 [thread overview]
Message-ID: <20090609132228.GC15949@redhat.com> (raw)
In-Reply-To: <200906091411.59723.paul@codesourcery.com>
On Tue, Jun 09, 2009 at 02:11:58PM +0100, Paul Brook wrote:
> On Tuesday 09 June 2009, Gleb Natapov wrote:
> > On Tue, Jun 09, 2009 at 02:01:52PM +0100, Paul Brook wrote:
> > > On Tuesday 09 June 2009, Gleb Natapov wrote:
> > > > Rename pci_irq_index to pci_device_count because this is what it
> > > > actually does.
> > >
> > > This whole thing looks bogus. AFAICS the limit is completely arbitrary
> > > and unnecessary.
> >
> > So? Left it bogus with unused field and cryptic name instead?
>
> No. Remove the whole thing.
Well, not with may understanding of that code, but if somebody wants to
do it...
--
Gleb.
prev parent reply other threads:[~2009-06-09 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 9:18 [Qemu-devel] [PATCHv2] remove unused field from pci device Gleb Natapov
2009-06-09 13:01 ` Paul Brook
2009-06-09 13:03 ` Gleb Natapov
2009-06-09 13:11 ` Paul Brook
2009-06-09 13:22 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609132228.GC15949@redhat.com \
--to=gleb@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).