From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME17b-0001ra-Ok for qemu-devel@nongnu.org; Tue, 09 Jun 2009 09:12:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME17X-0001pC-Fk for qemu-devel@nongnu.org; Tue, 09 Jun 2009 09:12:11 -0400 Received: from [199.232.76.173] (port=40149 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME17X-0001p9-7V for qemu-devel@nongnu.org; Tue, 09 Jun 2009 09:12:07 -0400 Received: from mx20.gnu.org ([199.232.41.8]:20886) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ME17W-0001fj-TM for qemu-devel@nongnu.org; Tue, 09 Jun 2009 09:12:07 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ME17V-00011g-Uu for qemu-devel@nongnu.org; Tue, 09 Jun 2009 09:12:06 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCHv2] remove unused field from pci device. Date: Tue, 9 Jun 2009 14:11:58 +0100 References: <20090609091831.GT27210@redhat.com> <200906091401.54908.paul@codesourcery.com> <20090609130336.GB15949@redhat.com> In-Reply-To: <20090609130336.GB15949@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906091411.59723.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org On Tuesday 09 June 2009, Gleb Natapov wrote: > On Tue, Jun 09, 2009 at 02:01:52PM +0100, Paul Brook wrote: > > On Tuesday 09 June 2009, Gleb Natapov wrote: > > > Rename pci_irq_index to pci_device_count because this is what it > > > actually does. > > > > This whole thing looks bogus. AFAICS the limit is completely arbitrary > > and unnecessary. > > So? Left it bogus with unused field and cryptic name instead? No. Remove the whole thing. Paul