From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME2pi-0006op-Cx for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:01:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME2pd-0006mb-Dy for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:01:49 -0400 Received: from [199.232.76.173] (port=36073 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME2pd-0006mM-5G for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:01:45 -0400 Received: from mx20.gnu.org ([199.232.41.8]:24479) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ME2pc-0001nF-M0 for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:01:44 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ME2pb-0005Dh-RH for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:01:44 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic Date: Tue, 9 Jun 2009 16:01:40 +0100 References: <1244545261-23679-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1244545261-23679-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906091601.41592.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann > + qdev_init_gpio_out(&sysdev->qdev, &s->parent_irq, 1); This should be using sysbus_init_irq. Paul