From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ME3iT-0005fU-PA
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:58:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ME3iO-0005e5-Vq
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:58:25 -0400
Received: from [199.232.76.173] (port=33116 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ME3iO-0005dx-SP
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:58:20 -0400
Received: from mx20.gnu.org ([199.232.41.8]:25509)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1ME3iO-0006g2-HA
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:58:20 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1ME3iN-0007SI-J0
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 11:58:19 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic
Date: Tue, 9 Jun 2009 16:58:15 +0100
References: <1244545261-23679-1-git-send-email-kraxel@redhat.com>
	<200906091632.19195.paul@codesourcery.com>
	<4A2E84F8.7020303@redhat.com>
In-Reply-To: <4A2E84F8.7020303@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906091658.15889.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tuesday 09 June 2009, Gerd Hoffmann wrote:
> On 06/09/09 17:32, Paul Brook wrote:
> > On Tuesday 09 June 2009, Gerd Hoffmann wrote:
> >> On 06/09/09 17:01, Paul Brook wrote:
> >>>> +    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
> >>>
> >>> This should be using sysbus_init_irq.
> >>>
> >>> Paul
> >>
> >> Patch 3/3 kills that line anyway ...
> >
> > It's still wrong.
>
> Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?

Because some devices have both IRQs and GPIO outputs.

Paul