From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ME5LM-0005tZ-2d
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 13:42:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ME5LG-0005tN-RA
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 13:42:39 -0400
Received: from [199.232.76.173] (port=41552 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ME5LG-0005tK-Nj
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 13:42:34 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41893)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@redhat.com>) id 1ME5LG-0004NV-56
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 13:42:34 -0400
Date: Tue, 9 Jun 2009 14:45:54 -0300
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3 12/13] qemu: virtio save/load bindings
Message-ID: <20090609174554.GD19375@poweredge.glommer>
References: <cover.1244192535.git.mst@redhat.com>
	<20090605102426.GM26770@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090605102426.GM26770@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

duplicated save config.

> diff --git a/hw/virtio.h b/hw/virtio.h
> index 04a3c3d..ce05517 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -72,6 +72,10 @@ typedef struct VirtQueueElement
>  
>  typedef struct {
>      void (*notify)(void * opaque, uint16_t vector);
> +    void (*save_config)(void * opaque, QEMUFile *f);
> +    void (*save_queue)(void * opaque, int n, QEMUFile *f);
> +    int (*load_config)(void * opaque, QEMUFile *f);
> +    int (*load_queue)(void * opaque, int n, QEMUFile *f);
>  } VirtIOBindings;
>  
So, what's the overall effect on a virtual machine that gets migrated,
of a certain device not implementing one of those functions? Will it work?
Will it break?