From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEB4y-0005hi-IC
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 19:50:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEB4t-0005Up-OC
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 19:50:07 -0400
Received: from [199.232.76.173] (port=45972 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEB4t-0005UY-Kw
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 19:50:03 -0400
Received: from mx20.gnu.org ([199.232.41.8]:35516)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MEB4t-0007AU-B9
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 19:50:03 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MEB4s-0002GT-LJ
	for qemu-devel@nongnu.org; Tue, 09 Jun 2009 19:50:02 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Wed, 10 Jun 2009 00:49:59 +0100
References: <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>
In-Reply-To: <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906100050.00389.paul@codesourcery.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3dcd219] Update irqs on
	reset and device load
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>

On Tuesday 09 June 2009, Anthony Liguori wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
>@@ -3314,6 +3314,8 @@ static int rtl8139_load(QEMUFile* f,void* opaque,int
> version_id) s->cplus_enabled = s->CpCmd != 0;
>     }
>
>+    rtl8139_update_irq(s);

This should not be necessary.

PCI bus multiplexers should save/restore their own internal state.

In fact this patch only works by chance, and relies on the fact that the bus 
multiplexers have no temporal state.

Paul