From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Glauber Costa <glommer@redhat.com>
Subject: [Qemu-devel] [PATCHv4 02/13] qemu: capability bits in pci save/restore
Date: Wed, 10 Jun 2009 15:28:12 +0300 [thread overview]
Message-ID: <20090610122812.GC27174@redhat.com> (raw)
In-Reply-To: <cover.1244635350.git.mst@redhat.com>
Add support for capability bits in save/restore for pci.
These will be used for MSI, where the capability might
be present or not as requested by user, which does not
map well into a single version number.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/pci.c | 17 ++++++++++++++---
hw/pci.h | 4 ++++
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 766e0c6..6740b07 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -126,9 +126,13 @@ int pci_bus_num(PCIBus *s)
void pci_device_save(PCIDevice *s, QEMUFile *f)
{
+ int version = s->cap_present ? 3 : 2;
int i;
- qemu_put_be32(f, 2); /* PCI device version */
+ /* PCI device version and capabilities */
+ qemu_put_be32(f, version);
+ if (version >= 3)
+ qemu_put_be32(f, s->cap_present);
qemu_put_buffer(f, s->config, 256);
for (i = 0; i < 4; i++)
qemu_put_be32(f, s->irq_state[i]);
@@ -140,15 +144,22 @@ int pci_device_load(PCIDevice *s, QEMUFile *f)
int i;
version_id = qemu_get_be32(f);
- if (version_id > 2)
+ if (version_id > 3)
return -EINVAL;
+ if (version_id >= 3)
+ s->cap_present = qemu_get_be32(f);
+ else
+ s->cap_present = 0;
+
+ if (s->cap_present & ~s->cap_supported)
+ return -EINVAL;
+
qemu_get_buffer(f, s->config, 256);
pci_update_mappings(s);
if (version_id >= 2)
for (i = 0; i < 4; i ++)
s->irq_state[i] = qemu_get_be32(f);
-
return 0;
}
diff --git a/hw/pci.h b/hw/pci.h
index c50ea50..656badc 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -174,6 +174,10 @@ struct PCIDevice {
/* Current IRQ levels. Used internally by the generic PCI code. */
int irq_state[4];
+
+ /* Capability bits for save/load */
+ uint32_t cap_supported;
+ uint32_t cap_present;
};
PCIDevice *pci_register_device(PCIBus *bus, const char *name,
--
1.6.3.1.56.g79e1.dirty
next prev parent reply other threads:[~2009-06-10 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1244635350.git.mst@redhat.com>
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 01/13] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-06-16 20:40 ` [Qemu-devel] " Anthony Liguori
2009-06-17 11:49 ` Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin [this message]
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 03/13] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 04/13] qemu: helper routines for pci access Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 05/13] qemu: MSI-X support functions Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 06/13] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 07/13] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 08/13] qemu: add support for resizing regions Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 09/13] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 10/13] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 11/13] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 12/13] qemu: virtio save/load bindings Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 13/13] qemu: add pci_get/set_byte Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610122812.GC27174@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).