From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEOYD-0006aM-LB
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 10:13:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEOY9-0006Xh-0b
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 10:13:13 -0400
Received: from [199.232.76.173] (port=40180 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEOY8-0006XX-R9
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 10:13:08 -0400
Received: from mx2.redhat.com ([66.187.237.31]:57937)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ehabkost@redhat.com>) id 1MEOY8-0002qg-GY
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 10:13:08 -0400
Date: Wed, 10 Jun 2009 11:12:55 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on
	configure
Message-ID: <20090610141255.GZ18045@blackpad>
References: <1244582792-30589-1-git-send-email-ehabkost@redhat.com>
	<1244582792-30589-3-git-send-email-ehabkost@redhat.com>
	<87ocsxoye4.fsf@lechat.rtp-net.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ocsxoye4.fsf@lechat.rtp-net.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

On Wed, Jun 10, 2009 at 12:06:27AM +0200, Arnaud Patard wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
> 
> Hi Eduardo,
> 
> > Some glibc versions don't have utimensat() available, but have other xxxat()
> > functions. Make a separated check for utimensat() to make sure we can compile
> > linux-user against some older glibc versions.
> 
> Why didn't you take the patches available in this thread
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01290.html ?

Because it is not included on the qemu tree.

> 
> afaik, they can also be found in maemo's qemu git tree (and sent again
> later to the mailing list)

Why is it not included, if it is a better fix?


> 
> [...]
> 
> > +#ifdef CONFIG_UTIMENSAT
> > +
> > +#ifdef TARGET_NR_utimensat
> > +static int sys_utimensat(int dirfd, const char *pathname,
> > +    const struct timespec times[2], int flags)
> > +{
> > +  return (utimensat(dirfd, pathname, times, flags));
> > +}
> 
> As you'll see when reading the thread I mentionned, this is broken.

I don't see why it is broken, unless current qemu code is broken too. I
just changed it to use the !CONFIG_ATFILE sys_utimensat() implementation
(that was already present on the code) if glibc doesn't provide
utimensat(). What do you suggest instead?

-- 
Eduardo