From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEPSf-0005kT-DM for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:11:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEPSa-0005cY-Nm for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:11:32 -0400 Received: from [199.232.76.173] (port=51371 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEPSa-0005c4-EJ for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:11:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:34013) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEPSY-0003ZH-Tw for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:11:27 -0400 Date: Wed, 10 Jun 2009 18:08:19 +0300 From: "Michael S. Tsirkin" Message-ID: <20090610150819.GD28601@redhat.com> References: <1243924970-17545-1-git-send-email-yamahata@valinux.co.jp> <1243924970-17545-2-git-send-email-yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1243924970-17545-2-git-send-email-yamahata@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH 1/7] vmware_vga: clean up List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, paul@codesourcery.com, avi@redhat.com On Tue, Jun 02, 2009 at 03:42:44PM +0900, Isaku Yamahata wrote: > use NULL instead of 0 for pci_register_device() argument > for consistency. Any other caller uses NULL. > > Signed-off-by: Isaku Yamahata ACK. Isn't this independend of other patches in the series? If yes, it's probably better to post them separately. Acked-by: Michael S. Tsirkin > --- > hw/vmware_vga.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c > index 79da1ff..ee4f10a 100644 > --- a/hw/vmware_vga.c > +++ b/hw/vmware_vga.c > @@ -1217,7 +1217,7 @@ void pci_vmsvga_init(PCIBus *bus) > /* Setup PCI configuration */ > s = (struct pci_vmsvga_state_s *) > pci_register_device(bus, "QEMUware SVGA", > - sizeof(struct pci_vmsvga_state_s), -1, 0, 0); > + sizeof(struct pci_vmsvga_state_s), -1, NULL, NULL); > pci_config_set_vendor_id(s->card.config, PCI_VENDOR_ID_VMWARE); > pci_config_set_device_id(s->card.config, SVGA_PCI_DEVICE_ID); > s->card.config[PCI_COMMAND] = 0x07; /* I/O + Memory */ > -- > 1.6.0.2 -- MST