From: Riku Voipio <riku.voipio@iki.fi>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/7] target-ppc: retain l{w,d}arx loaded value
Date: Wed, 10 Jun 2009 18:59:52 +0300 [thread overview]
Message-ID: <20090610155952.GA12221@kos.to> (raw)
In-Reply-To: <1244141522-21802-5-git-send-email-froydnj@codesourcery.com>
Not that I can really review this patch, but;
On Thu, Jun 04, 2009 at 11:51:59AM -0700, Nathan Froyd wrote:
> GEN_HANDLER(ldarx, 0x1F, 0x14, 0x02, 0x00000001, PPC_64B)
> {
> TCGv t0;
> + TCGv gpr = cpu_gpr[rD(ctx->opcode)];
> gen_set_access_type(ctx, ACCESS_RES);
> t0 = tcg_temp_local_new();
> gen_addr_reg_index(ctx, t0);
> gen_check_align(ctx, t0, 0x07);
> - gen_qemu_ld64(ctx, cpu_gpr[rD(ctx->opcode)], t0);
> + gen_qemu_ld64(ctx, gpr, t0);
> tcg_gen_mov_tl(cpu_reserve, t0);
> + tcg_gen_st_tl(gpr, cpu_env, offsetof(CPUState, reserve_val);
missing a closing parens?
> tcg_temp_free(t0);
> }
next prev parent reply other threads:[~2009-06-10 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 18:51 [Qemu-devel] [PATCH 0/7] target-ppc/linux-user: NPTL support Nathan Froyd
2009-06-04 18:51 ` [Qemu-devel] [PATCH 1/7] linux-user: initialize mmap_mutex properly Nathan Froyd
2009-06-04 18:51 ` [Qemu-devel] [PATCH 2/7] target-ppc: fix cpu_clone_regs Nathan Froyd
2009-06-04 18:51 ` [Qemu-devel] [PATCH 3/7] target-ppc: add cpu_set_tls Nathan Froyd
2009-06-04 18:51 ` [Qemu-devel] [PATCH 4/7] target-ppc: retain l{w,d}arx loaded value Nathan Froyd
2009-06-10 15:59 ` Riku Voipio [this message]
2009-06-04 18:52 ` [Qemu-devel] [PATCH 5/7] target-ppc: add exceptions for conditional stores Nathan Froyd
2009-06-04 18:52 ` [Qemu-devel] [PATCH 6/7] linux-user: handle POWERPC_EXCP_STCX Nathan Froyd
2009-06-04 18:52 ` [Qemu-devel] [PATCH 7/7] enable NPTL for ppc-linux-user targets in configure Nathan Froyd
2009-06-05 23:04 ` [Qemu-devel] [PATCH 0/7] target-ppc/linux-user: NPTL support malc
2009-06-06 2:56 ` Paul Brook
2009-07-06 15:28 ` Nathan Froyd
2009-06-09 23:37 ` Miklos Vajna
2009-06-10 0:24 ` Daniel Jacobowitz
2009-06-10 0:30 ` Miklos Vajna
2009-06-10 2:49 ` Daniel Jacobowitz
2009-06-10 9:31 ` Miklos Vajna
2009-06-10 0:57 ` Laurent Vivier
2009-06-10 9:28 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610155952.GA12221@kos.to \
--to=riku.voipio@iki.fi \
--cc=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).