From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEQDW-0005Rl-E7
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:59:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEQDV-0005RR-Ed
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:59:58 -0400
Received: from [199.232.76.173] (port=55683 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEQDV-0005RO-Bb
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:59:57 -0400
Received: from naru.obs2.net ([84.20.150.76]:48400)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1MEQDU-0003Ld-Sv
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 11:59:57 -0400
Date: Wed, 10 Jun 2009 18:59:52 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH 4/7] target-ppc: retain l{w,d}arx loaded value
Message-ID: <20090610155952.GA12221@kos.to>
References: <1244141522-21802-1-git-send-email-froydnj@codesourcery.com>
	<1244141522-21802-5-git-send-email-froydnj@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1244141522-21802-5-git-send-email-froydnj@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org

Not that I can really review this patch, but;

On Thu, Jun 04, 2009 at 11:51:59AM -0700, Nathan Froyd wrote:
>  GEN_HANDLER(ldarx, 0x1F, 0x14, 0x02, 0x00000001, PPC_64B)
>  {
>      TCGv t0;
> +    TCGv gpr = cpu_gpr[rD(ctx->opcode)];
>      gen_set_access_type(ctx, ACCESS_RES);
>      t0 = tcg_temp_local_new();
>      gen_addr_reg_index(ctx, t0);
>      gen_check_align(ctx, t0, 0x07);
> -    gen_qemu_ld64(ctx, cpu_gpr[rD(ctx->opcode)], t0);
> +    gen_qemu_ld64(ctx, gpr, t0);
>      tcg_gen_mov_tl(cpu_reserve, t0);
> +    tcg_gen_st_tl(gpr, cpu_env, offsetof(CPUState, reserve_val);

missing a closing parens?

>      tcg_temp_free(t0);
>  }