From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEQL5-0007x2-0L for qemu-devel@nongnu.org; Wed, 10 Jun 2009 12:07:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEQL3-0007vw-1g for qemu-devel@nongnu.org; Wed, 10 Jun 2009 12:07:45 -0400 Received: from [199.232.76.173] (port=57784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEQL2-0007vm-Q2 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 12:07:44 -0400 Received: from naru.obs2.net ([84.20.150.76]:48607) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MEQL2-0004ZY-15 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 12:07:44 -0400 Date: Wed, 10 Jun 2009 19:07:42 +0300 From: Riku Voipio Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure Message-ID: <20090610160742.GB12221@kos.to> References: <1244582792-30589-1-git-send-email-ehabkost@redhat.com> <1244582792-30589-3-git-send-email-ehabkost@redhat.com> <87ocsxoye4.fsf@lechat.rtp-net.org> <20090610141255.GZ18045@blackpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090610141255.GZ18045@blackpad> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnaud Patard , Anthony Liguori , Glauber Costa , qemu-devel@nongnu.org On Wed, Jun 10, 2009 at 11:12:55AM -0300, Eduardo Habkost wrote: > > afaik, they can also be found in maemo's qemu git tree (and sent again > > later to the mailing list) > Why is it not included, if it is a better fix? because mainline qemu is lacking a linux-user maintainer. The maemo tree's linux-user-for-upstream branch hasn't been updated either for a while, I'll do so tonight. > > As you'll see when reading the thread I mentionned, this is broken. > I don't see why it is broken, unless current qemu code is broken too. I > just changed it to use the !CONFIG_ATFILE sys_utimensat() implementation > (that was already present on the code) if glibc doesn't provide > utimensat(). What do you suggest instead? As can be deduced from the thread, yes the current qemu code is broken.