From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEHed-00061M-Jg
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 02:51:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEHeY-00061A-Tg
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 02:51:23 -0400
Received: from [199.232.76.173] (port=37801 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEHeY-000617-OM
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 02:51:18 -0400
Received: from mx20.gnu.org ([199.232.41.8]:44069)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rusty@rustcorp.com.au>)
	id 1MEHeY-0003nZ-1K
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 02:51:18 -0400
Received: from ozlabs.org ([203.10.76.45])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rusty@rustcorp.com.au>) id 1MEHeX-0000Lx-0w
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 02:51:17 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements
Date: Wed, 10 Jun 2009 16:21:07 +0930
References: <20090605204647.3355.81929.stgit@kvm.aw>
	<1244575510.11883.172.camel@blaa>
In-Reply-To: <1244575510.11883.172.camel@blaa>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200906101621.07565.rusty@rustcorp.com.au>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org, Alex Williamson <alex.williamson@hp.com>

On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote:
> Hi Alex,
>
> On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:
> > This series cleans up a few things around packet filtering.  I've
> > probably gone a little overboard on breaking up patches, if we want to
> > avoid bumping the save version_id so much, these could be mostly lumped
> > together.  The main features here are more efficient handling of the
> > filtering between unicast and multicast, better overflow tracking, adding
> > more RX modes, and increasing the size of the filter table and control
> > queue depth.
>
> The whole series looks good to me. Please make sure to send Rusty a
> patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.

Remain unconvinced that it's worth a feature bit.  It'd pretty obscure (hell, 
even multicast is pretty obscure IRL).

Thanks,
Rusty.