From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1METCG-0001Wr-2M
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:10:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1METCA-0001W3-Mi
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:10:50 -0400
Received: from [199.232.76.173] (port=35021 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1METCA-0001W0-HJ
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:10:46 -0400
Received: from mx20.gnu.org ([199.232.41.8]:1374)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1METCA-0003IZ-3a
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:10:46 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1METC9-00070H-Cb
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 15:10:45 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] Add device tree machine
Date: Wed, 10 Jun 2009 20:10:42 +0100
References: <20090610173803.4674.82538.stgit@wren.home>
	<20090610173821.4674.58171.stgit@wren.home>
	<f43fc5580906101130v4f83d5c6wa13b42e0ca550662@mail.gmail.com>
In-Reply-To: <f43fc5580906101130v4f83d5c6wa13b42e0ca550662@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906102010.43228.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

> >   if test "$preadv" = "yes" ; then
> >  -  echo "#define HAVE_PREADV 1" >> $config_h
> >  +  echo "#defne HAVE_PREADV 1" >> $config_h
>
> #defne?

Oops. I've sure I've already fixed that at least twice...

> >  +    buf = qemu_mallocz(strlen(name) + 5);
> >  +    sprintf(buf, "%s.dtb", name);
>
> snprintf?

Bah. Stoopid paranoid OpenBSD. :-)

Paul