From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEVeo-0002NE-KX for qemu-devel@nongnu.org; Wed, 10 Jun 2009 17:48:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEVeo-0002Mt-4u for qemu-devel@nongnu.org; Wed, 10 Jun 2009 17:48:30 -0400 Received: from [199.232.76.173] (port=59450 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEVeo-0002Ml-14 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 17:48:30 -0400 Received: from naru.obs2.net ([84.20.150.76]:56370) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MEVem-0005O5-M0 for qemu-devel@nongnu.org; Wed, 10 Jun 2009 17:48:29 -0400 Date: Thu, 11 Jun 2009 00:48:26 +0300 From: Riku Voipio Subject: Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure Message-ID: <20090610214826.GC23525@kos.to> References: <1244582792-30589-1-git-send-email-ehabkost@redhat.com> <1244582792-30589-3-git-send-email-ehabkost@redhat.com> <87ocsxoye4.fsf@lechat.rtp-net.org> <20090610141255.GZ18045@blackpad> <87bpownof6.fsf@lechat.rtp-net.org> <1244659259-sup-8660@blackpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1244659259-sup-8660@blackpad> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Glauber Costa , qemu-devel , Arnaud Patard On Wed, Jun 10, 2009 at 04:10:33PM -0300, Eduardo Habkost wrote: > > glibc utimensat is not exactly the syscall, a test on some parameters > > has been added. There's code to handle this in the patch I was talking > > about. > Understood. However, my patch addresses a different issue, that is the > case where the host system doesn't have utimensat() available. The point > here is to disable the code that uses utimensat() (be it broken or not) > on that case. > And the first patch is unrelated to that question: it is just a > correctness issue to make sure the xxxat() availability matches the > situation detected by ./configure (whose test code has #define > _ATFILE_SOURCE). You mean like this, in the same thread? :) http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01324.html However your other patch was useful, _ATFILE_SOURCE should be used in syscall.c to. thanks, applied to the maemo tree.