From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEbwy-0004W2-5H for qemu-devel@nongnu.org; Thu, 11 Jun 2009 00:31:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEbws-0004Tg-Mq for qemu-devel@nongnu.org; Thu, 11 Jun 2009 00:31:38 -0400 Received: from [199.232.76.173] (port=59119 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEbws-0004Td-GE for qemu-devel@nongnu.org; Thu, 11 Jun 2009 00:31:34 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41448) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEbwr-0005vF-Vv for qemu-devel@nongnu.org; Thu, 11 Jun 2009 00:31:34 -0400 Date: Thu, 11 Jun 2009 10:01:30 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH] virtio-serial: PCI device for simple host <-> guest communication Message-ID: <20090611043130.GB22914@amit-x200.pnq.redhat.com> References: <1244565768-9103-1-git-send-email-amit.shah@redhat.com> <1244565768-9103-2-git-send-email-amit.shah@redhat.com> <1244565768-9103-3-git-send-email-amit.shah@redhat.com> <1244565768-9103-4-git-send-email-amit.shah@redhat.com> <20090609181714.GB11485@amd.home.annexia.org> <4A2EB079.6020909@codemonkey.ws> <20090610103115.GB12327@amit-x200.pnq.redhat.com> <20090610180027.GF7416@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090610180027.GF7416@shareable.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: "Richard W.M. Jones" , qemu-devel@nongnu.org On (Wed) Jun 10 2009 [19:00:27], Jamie Lokier wrote: > Amit Shah wrote: > > > Plus, having a virtio serial device and a virtio console seems > > > unfortunate to me. Anyway we can unify the two? Maybe make virtio > > > serial support hvc with a feature flag or something instead of ttyS? > > > > Yes, it's possible. I'll look into that once I reach a point where > > virtio-serial is ready to be merged. I'll also have to look at making > > sure existing guest kernels work with the new, unified device. > > One of the most useful things about a serial port is that it's so easy > for basic OS components like debuggers and bootloaders and BIOSes to > use it, with very little code, and without having to do very complex > things like initialise and enumerate PCI buses etc., and without > interference by an OS so they are useful for things like kernel > debugging and reliable debugging output. > > For this reason, virtually every real machine has a simple serial > port, even if it isn't exposed on an external connector. > > Are virtio-serial/virtio-console very simple to drive from guest code, > without PCI enumeration, or do they require complex initialisation and > OS cooperation? OK, great question. I'll post my Linux driver that'll answer your question precisely, but this is what a guest userspace app will have to do to use it: fd = open("/dev/vmser0", O_RDWR); if (fd == -1) { perror("open"); return -errno; } ret = read(fd, buf, 100); if (ret < 0) { perror("read"); } ret = ioctl(fd, VIRTIO_SERIAL_IOCTL_GET_PORT_NAME, &port_name); if (ret) perror("ioctl"); printf("string is %s\n", port_name.name); So the guest driver exposes a simple char device to userspace. The driver itself hooks up with the virtio code which abstracts away all the pci stuff. It just has to manage the rings and the queues. Amit