From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEilp-0008AY-SO
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 07:48:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEilk-00085j-Bg
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 07:48:36 -0400
Received: from [199.232.76.173] (port=36529 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEilk-00085Z-40
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 07:48:32 -0400
Received: from mx20.gnu.org ([199.232.41.8]:35131)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MEilj-0006gc-72
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 07:48:31 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MEilf-0002r4-Oh
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 07:48:28 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: Networking patches queue
Date: Thu, 11 Jun 2009 12:48:21 +0100
References: <1243523971.4046.206.camel@blaa> <1244583818.7164.19.camel@blaa>
In-Reply-To: <1244583818.7164.19.camel@blaa>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906111248.22091.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Mark McLoughlin <markmc@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, Alex Williamson <alex.williamson@hp.com>

On Tuesday 09 June 2009, Mark McLoughlin wrote:
>       net: add return value to packet receive handler (4f1c942b7f)

This patch is wrong. We already have a can_receive handler for this purpose.  
Having this callback and allowing receive to fail is just silly. One or the 
other, but not both.

Paul