From: Gleb Natapov <gleb@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Register uhci_reset() callback.
Date: Thu, 11 Jun 2009 17:00:54 +0300 [thread overview]
Message-ID: <20090611140054.GD19508@redhat.com> (raw)
In-Reply-To: <200906111453.13421.paul@codesourcery.com>
On Thu, Jun 11, 2009 at 02:53:12PM +0100, Paul Brook wrote:
> On Thursday 11 June 2009, Gleb Natapov wrote:
> > On Thu, Jun 11, 2009 at 02:41:33PM +0100, Paul Brook wrote:
> > > On Thursday 11 June 2009, Gleb Natapov wrote:
> > > > Update IRQ line on reset.
> > >
> > > This should not be necessary.
> >
> > You are always so brief. Can you please spent a little bit more time and
> > afford and explain why is should not be necessary, because it is clear
> > that I think it is that is why I put it there in the first place.
>
> Ok. Let me put this annother way.
You don't think registering reset is not necessary or you don't think
calling uhci_update_irq(s) in the reset handler is necessary?
> I don't think this is necessary. What bug are you fixing, and why is this the
> right solution?
RHEL4.8 hangs after reboot because usb interrupt is not goes away. This
patch fixes it. Reseting all devices on a system reset is a right thing to do
even if there is no reproducible bug exist.
--
Gleb.
next prev parent reply other threads:[~2009-06-11 14:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 8:48 [Qemu-devel] Register uhci_reset() callback Gleb Natapov
2009-06-11 13:41 ` Paul Brook
2009-06-11 13:46 ` Gleb Natapov
2009-06-11 13:53 ` Paul Brook
2009-06-11 14:00 ` Gleb Natapov [this message]
2009-06-11 16:38 ` Jamie Lokier
2009-06-11 16:40 ` Gleb Natapov
2009-06-15 16:20 ` Avi Kivity
2009-06-16 15:00 ` Jamie Lokier
2009-06-16 15:18 ` Avi Kivity
2009-06-16 15:43 ` Jamie Lokier
2009-06-15 16:21 ` Avi Kivity
2009-06-15 17:02 ` Gleb Natapov
2009-06-15 17:17 ` Avi Kivity
2009-06-15 17:21 ` Gleb Natapov
2009-06-15 17:56 ` Paul Brook
2009-06-15 18:16 ` Gleb Natapov
2009-06-15 18:57 ` Blue Swirl
2009-06-15 19:30 ` Gleb Natapov
2009-06-15 19:50 ` Blue Swirl
2009-06-15 20:05 ` Gleb Natapov
2009-06-16 15:14 ` Blue Swirl
2009-06-16 15:20 ` Gleb Natapov
2009-06-16 16:54 ` Blue Swirl
2009-06-16 17:09 ` Gleb Natapov
2009-06-16 17:19 ` Blue Swirl
2009-06-16 18:39 ` Gleb Natapov
2009-06-18 9:20 ` Avi Kivity
2009-06-16 16:54 ` Paul Brook
2009-06-16 17:12 ` Blue Swirl
2009-06-16 18:00 ` Paul Brook
2009-06-16 18:10 ` Blue Swirl
2009-06-16 18:52 ` Jamie Lokier
2009-06-16 19:05 ` Jamie Lokier
2009-06-16 19:10 ` Blue Swirl
2009-06-16 19:23 ` Gleb Natapov
2009-06-16 19:16 ` Paul Brook
2009-06-16 17:47 ` Gleb Natapov
2009-06-16 17:04 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611140054.GD19508@redhat.com \
--to=gleb@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).