From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEkrw-0006px-NY
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 10:03:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEkrr-0006f7-OW
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 10:03:04 -0400
Received: from [199.232.76.173] (port=58059 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEkrr-0006eX-JR
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 10:02:59 -0400
Received: from mx2.redhat.com ([66.187.237.31]:42868)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MEkrq-0001Oq-Le
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 10:02:58 -0400
Date: Thu, 11 Jun 2009 17:00:54 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] Register uhci_reset() callback.
Message-ID: <20090611140054.GD19508@redhat.com>
References: <20090611084808.GA19508@redhat.com>
	<200906111441.34151.paul@codesourcery.com>
	<20090611134656.GC19508@redhat.com>
	<200906111453.13421.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200906111453.13421.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Thu, Jun 11, 2009 at 02:53:12PM +0100, Paul Brook wrote:
> On Thursday 11 June 2009, Gleb Natapov wrote:
> > On Thu, Jun 11, 2009 at 02:41:33PM +0100, Paul Brook wrote:
> > > On Thursday 11 June 2009, Gleb Natapov wrote:
> > > > Update IRQ line on reset.
> > >
> > > This should not be necessary.
> >
> > You are always so brief. Can you please spent a little bit more time and
> > afford and explain why is should not be necessary, because it is clear
> > that I think it is that is why I put it there in the first place.
> 
> Ok. Let me put this annother way.
You don't think registering reset is not necessary or you don't think
calling uhci_update_irq(s) in the reset handler is necessary?

> I don't think this is necessary. What bug are you fixing, and why is this the 
> right solution?
RHEL4.8 hangs after reboot because usb interrupt is not goes away. This
patch fixes it. Reseting all devices on a system reset is a right thing to do
even if there is no reproducible bug exist. 

--
			Gleb.