From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEkVC-0000CA-VM
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:39:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEkV8-00006C-4z
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:39:34 -0400
Received: from [199.232.76.173] (port=44357 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEkV7-00005u-VN
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:39:29 -0400
Received: from mx20.gnu.org ([199.232.41.8]:41371)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MEkV7-00048p-IQ
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:39:29 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MEkV6-0002Qi-LM
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:39:28 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] Add device tree machine
Date: Thu, 11 Jun 2009 14:39:25 +0100
References: <20090610173803.4674.82538.stgit@wren.home>
	<20090610173821.4674.58171.stgit@wren.home>
	<4A31078C.9000403@redhat.com>
In-Reply-To: <4A31078C.9000403@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906111439.26304.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thursday 11 June 2009, Gerd Hoffmann wrote:
> A few more comments ...
>
> > +static void dt_add_props(DeviceState *dev, void *dt, int offset)
> > +{
>
> Where do device properties come from?  Only the fdt tree?  If so, do we
> need the property lists in the first place?  We could get them directly
> from the fdt tree instead.

The FDT doesn't contain any type information.  My initial implementation 
omitted DevicePropertyList altogether. That ended up fairly messy. Also, when 
we're using the same tree for both qemu and linux the tree probably has 
additional properties we don't care about.

Paul