From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEk2x-0000tU-R1
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:10:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEk2r-0000pd-Qj
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:10:22 -0400
Received: from [199.232.76.173] (port=54515 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEk2r-0000pa-MZ
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:10:17 -0400
Received: from wa4ehsobe005.messaging.microsoft.com ([216.32.181.15]:8623
	helo=WA4EHSOBE005.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1MEk2r-0002Zg-AT
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 09:10:17 -0400
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 15:10:03 +0200
References: <200906111335.10116.paul@codesourcery.com>
	<0E91747D-CD3F-4BB4-827B-E3415CAE4650@adacore.com>
In-Reply-To: <0E91747D-CD3F-4BB4-827B-E3415CAE4650@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200906111510.03812.Christoph.Egger@amd.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Tristan Gingold <gingold@adacore.com>, Paul Brook <paul@codesourcery.com>

On Thursday 11 June 2009 14:46:18 Tristan Gingold wrote:
> On Jun 11, 2009, at 2:35 PM, Paul Brook wrote:
> > I'd like to enable Werror by default. I've been using --enable-
> > werror locally
> > for a while now, and it's been extremely useful in picking up dumb
> > errors
> > (like the recent stellaris_enet.c breakage).
> >
> > Any objections?
>
> IIRC, qemu is not warnings clean on Darwin.
> But adding -Werror may increase the pressure :-)

pthreads are not -Wshadow or -Wnested-extern warning clean by design
on many OS's.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632