qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 18:24:45 +0100	[thread overview]
Message-ID: <20090611172445.GA6932@miranda.arrow> (raw)
In-Reply-To: <60cad3f0906110818x5893ce65w945a65568c2adf33@mail.gmail.com>

On Thu, Jun 11, 2009 at 05:18:27PM +0200, David Turner wrote:
> Even changing compiler versions can result in very surprising things.

For this reason, amongst others, I prefer not to use -Werror by default.

I gather that changing code optimisation settings can also result in
surprising things... and then there's FORTIFY_SOURCE...

Using more specific options such as -Werror=format on versions of GCC
that support it might be more reasonable... but care needs to be taken.
-Werror[=-]implicit-function-declaration is probably a sensible one, but
note that GCC 4.4 seems to have a different name for that option than
earlier releases.

Otherwise, you can almost certainly guarantee there there will be 
distributions that forget to disable -Werror, forcing you to alter their
packages to get them to build. :-(

Note also that enabling -Werror will *discourage* the use of additional
warning options that would be helpful, despite being slightly noisy.
-- 
Stuart Brady

      reply	other threads:[~2009-06-11 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 12:35 [Qemu-devel] [RFC] Enable Werrror by default Paul Brook
2009-06-11 12:46 ` Tristan Gingold
2009-06-11 13:10   ` Christoph Egger
2009-06-11 14:02   ` Andreas Färber
2009-06-11 12:58 ` Anthony Liguori
2009-06-11 13:14 ` Mark McLoughlin
2009-06-11 13:34   ` Christoph Egger
2009-06-11 13:35   ` Paul Brook
2009-06-11 14:20   ` Richard W.M. Jones
2009-06-11 18:30   ` Anthony Liguori
2009-06-11 18:38     ` Mark McLoughlin
2009-06-11 20:03       ` Anthony Liguori
2009-06-11 22:28     ` Paul Brook
2009-06-11 15:18 ` David Turner
2009-06-11 17:24   ` Stuart Brady [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611172445.GA6932@miranda.arrow \
    --to=sdbrady@ntlworld.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).