From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MEo1L-0001hZ-1l for qemu-devel@nongnu.org; Thu, 11 Jun 2009 13:24:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MEo1F-0001fm-N2 for qemu-devel@nongnu.org; Thu, 11 Jun 2009 13:24:58 -0400 Received: from [199.232.76.173] (port=37715 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MEo1F-0001fa-Gk for qemu-devel@nongnu.org; Thu, 11 Jun 2009 13:24:53 -0400 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:52288) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEo1E-0003o6-Ut for qemu-devel@nongnu.org; Thu, 11 Jun 2009 13:24:53 -0400 Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090611172448.FIYN6742.mtaout01-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com> for ; Thu, 11 Jun 2009 18:24:48 +0100 Received: from miranda.arrow ([213.107.24.213]) by aamtaout02-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090611172448.IYZP21638.aamtaout02-winn.ispmail.ntl.com@miranda.arrow> for ; Thu, 11 Jun 2009 18:24:48 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1MEo17-0001oS-JY for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:24:45 +0100 Date: Thu, 11 Jun 2009 18:24:45 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default Message-ID: <20090611172445.GA6932@miranda.arrow> References: <200906111335.10116.paul@codesourcery.com> <60cad3f0906110818x5893ce65w945a65568c2adf33@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60cad3f0906110818x5893ce65w945a65568c2adf33@mail.gmail.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jun 11, 2009 at 05:18:27PM +0200, David Turner wrote: > Even changing compiler versions can result in very surprising things. For this reason, amongst others, I prefer not to use -Werror by default. I gather that changing code optimisation settings can also result in surprising things... and then there's FORTIFY_SOURCE... Using more specific options such as -Werror=format on versions of GCC that support it might be more reasonable... but care needs to be taken. -Werror[=-]implicit-function-declaration is probably a sensible one, but note that GCC 4.4 seems to have a different name for that option than earlier releases. Otherwise, you can almost certainly guarantee there there will be distributions that forget to disable -Werror, forcing you to alter their packages to get them to build. :-( Note also that enabling -Werror will *discourage* the use of additional warning options that would be helpful, despite being slightly noisy. -- Stuart Brady