qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 23:28:38 +0100	[thread overview]
Message-ID: <200906112328.39127.paul@codesourcery.com> (raw)
In-Reply-To: <4A314D2D.2060505@codemonkey.ws>

> How about the following?  It currently only enables werror for Linux
> hosts and git builds.
>+    z_version=`cut -f3 -d. $source_path/VERSION`
>+    if test "$z_version" = "50" -a \

Looks ok to me.
FWIW I think testing for the presence of .git would be a bad idea.

Paul

  parent reply	other threads:[~2009-06-11 22:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 12:35 [Qemu-devel] [RFC] Enable Werrror by default Paul Brook
2009-06-11 12:46 ` Tristan Gingold
2009-06-11 13:10   ` Christoph Egger
2009-06-11 14:02   ` Andreas Färber
2009-06-11 12:58 ` Anthony Liguori
2009-06-11 13:14 ` Mark McLoughlin
2009-06-11 13:34   ` Christoph Egger
2009-06-11 13:35   ` Paul Brook
2009-06-11 14:20   ` Richard W.M. Jones
2009-06-11 18:30   ` Anthony Liguori
2009-06-11 18:38     ` Mark McLoughlin
2009-06-11 20:03       ` Anthony Liguori
2009-06-11 22:28     ` Paul Brook [this message]
2009-06-11 15:18 ` David Turner
2009-06-11 17:24   ` Stuart Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906112328.39127.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).