From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEslP-0006xG-BN
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:28:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEslJ-0006rd-R3
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:28:50 -0400
Received: from [199.232.76.173] (port=49791 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEslJ-0006rM-Lr
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:28:45 -0400
Received: from mx20.gnu.org ([199.232.41.8]:59936)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MEslJ-0004jZ-EF
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:28:45 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MEslH-0005UK-ET
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 18:28:43 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 23:28:38 +0100
References: <200906111335.10116.paul@codesourcery.com>
	<1244726086.7752.25.camel@blaa> <4A314D2D.2060505@codemonkey.ws>
In-Reply-To: <4A314D2D.2060505@codemonkey.ws>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906112328.39127.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>

> How about the following?  It currently only enables werror for Linux
> hosts and git builds.
>+    z_version=`cut -f3 -d. $source_path/VERSION`
>+    if test "$z_version" = "50" -a \

Looks ok to me.
FWIW I think testing for the presence of .git would be a bad idea.

Paul