From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support.
Date: Fri, 12 Jun 2009 12:22:45 +0100 [thread overview]
Message-ID: <200906121222.46360.paul@codesourcery.com> (raw)
In-Reply-To: <1244798921-23262-4-git-send-email-kraxel@redhat.com>
On Friday 12 June 2009, Gerd Hoffmann wrote:
> +
> + if (bus) {
> + d = scsi_create_simple(bus, "scsi-disk");
> + } else {
> + /* temporary until usb is qdev-ified */
> + d = (SCSIDevice *)qemu_mallocz(sizeof(SCSIDevice));
>+static void scsi_disk_initfn(SCSIDevice *dev)
>+{
>+ /* TODO */
>+}
These are both fairly good indicators that this patch is nowhere near ready
for integration. The whole point of the qdev API is to abstract device
creation from individual device implementation details. Your implementation
has the abstraction layers completely backwards.
The I2C code is an example of how a secondary bus should work.
Paul
next prev parent reply other threads:[~2009-06-12 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 9:28 [Qemu-devel] [PATCH 0/4] qdev patches Gerd Hoffmann
2009-06-12 9:28 ` [Qemu-devel] [PATCH 1/4] qdev: update pci device registration Gerd Hoffmann
2009-06-12 9:28 ` [Qemu-devel] [PATCH 2/4] qdev: replace bus_type enum with bus_info struct Gerd Hoffmann
2009-06-12 9:28 ` [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support Gerd Hoffmann
2009-06-12 11:22 ` Paul Brook [this message]
2009-06-12 14:58 ` Gerd Hoffmann
2009-06-12 9:28 ` [Qemu-devel] [PATCH 4/4] qdev: hook up i440fx Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906121222.46360.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).