From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MG9Td-0008TE-76
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 06:31:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MG9TY-0008Nu-Aq
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 06:31:44 -0400
Received: from [199.232.76.173] (port=59487 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MG9TY-0008Nf-2A
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 06:31:40 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51610)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MG9TX-0002W6-BS
	for qemu-devel@nongnu.org; Mon, 15 Jun 2009 06:31:39 -0400
Date: Mon, 15 Jun 2009 13:29:21 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3
	03/13] qemu: add routines to manage PCI capabilities]
Message-ID: <20090615102921.GA6351@redhat.com>
References: <20090610174301.GC7416@shareable.org>
	<20090610182227.GN28601@redhat.com>
	<20090610192702.GH7416@shareable.org>
	<1244796209.16425.20.camel@blaa> <4A326B5C.5010501@codemonkey.ws>
	<1244821292.30522.56.camel@blaa> <4A327E4A.7010300@codemonkey.ws>
	<1244825303.26769.19.camel@blaa> <20090614095016.GA7560@redhat.com>
	<4A3617D4.5090405@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A3617D4.5090405@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, kvm@vger.kernel.org, Carsten Otte <cotte@de.ibm.com>, Glauber Costa <glommer@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>

On Mon, Jun 15, 2009 at 12:43:48PM +0300, Avi Kivity wrote:
> On 06/14/2009 12:50 PM, Michael S. Tsirkin wrote:
>> On Fri, Jun 12, 2009 at 05:48:23PM +0100, Mark McLoughlin wrote:
>>    
>>> However, in order to retain compat for that SCSI device (e.g. ensuring
>>> the PCI address doesn't change as other devices are added an removed),
>>> we're back to the same problem ... either:
>>>
>>>    1) Use '-drive file=foo.img,if=scsi,pci_addr=foo'; in order to figure
>>>       out what address to use, libvirt would need to query qemu for what
>>>       address was originally allocated to device or it would do all the
>>>       PCI address allocation itself ...
>>>      
>>
>> This last option makes sense to me: in a real world the user has
>> control over where he places the device on the bus, so why
>> not with qemu?
>>    
>
> Yes, the user build the machine using the command line and monitor (or,  
> in 2017, the machine configuration file), then turns on the power.   
> Command line options are the parts lying around when we start.
>
> btw, -drive needs to be separated:
>
>   -controller type=lsi1234,pci_addr=foobar,name=blah
>   -drive file=foo.img,controller=blah,index=0
>   -drive file=bar.img,controller=blah,index=1
>
> Drives to not have pci addresses.

Maybe we need a generic 'bus options' flag.