Re: [Qemu-devel] Register uhci_reset() callback.

[Gleb Natapov <gleb@redhat.com>]

On Mon, Jun 15, 2009 at 08:17:08PM +0300, Avi Kivity wrote:
> On 06/15/2009 08:02 PM, Gleb Natapov wrote:
>> On Mon, Jun 15, 2009 at 07:21:09PM +0300, Avi Kivity wrote:
>>    
>>> On 06/11/2009 04:46 PM, Gleb Natapov wrote:
>>>      
>>>> On Thu, Jun 11, 2009 at 02:41:33PM +0100, Paul Brook wrote:
>>>>
>>>>        
>>>>> On Thursday 11 June 2009, Gleb Natapov wrote:
>>>>>
>>>>>          
>>>>>> Update IRQ line on reset.
>>>>>>
>>>>>>            
>>>>> This should not be necessary.
>>>>>
>>>>>
>>>>>          
>>>> You are always so brief.
>>>>        
>>> To be fair, so are you.
>>>
>>>      
>> May be, but in this case after previous patch to reset interrupt level
>> for each device at PCI bridge level was rejected on the premise that
>> device should lower its own irq line on reset and since patches started
>> flowing in to do just that, I did not expect that eloquent explanation
>> would be needed for such trivial and obviously correct change.
>>    
>
> Citing which guests are unbroken by the patch, for example, would have  
> helped.  As someone who accepts a lot of excellent patches from you, I  
> also find the change logs to be laconic.
>
I agree, I will resend the patch with more detailed changelog. But reset
handler should be added to each device (and PCI devices reset should
lower interrupt line since it may be shared) even if there is no
reproducible test case to show.

I'll try to work on improving my commit logs :)

--
			Gleb.