From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] readline: Remove unneeded qemu_mallocz() check
Date: Mon, 15 Jun 2009 17:37:31 -0300 [thread overview]
Message-ID: <20090615173731.026e9fa9@doriath> (raw)
qemu_mallocz() already checks for NULL returns, readline_init() doesn't
have to do it again.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
readline.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/readline.c b/readline.c
index 9c500f1..7834af0 100644
--- a/readline.c
+++ b/readline.c
@@ -467,9 +467,6 @@ ReadLineState *readline_init(Monitor *mon,
{
ReadLineState *rs = qemu_mallocz(sizeof(*rs));
- if (!rs)
- return NULL;
-
rs->hist_entry = -1;
rs->mon = mon;
rs->completion_finder = completion_finder;
--
1.6.3.GIT
next reply other threads:[~2009-06-15 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 20:37 Luiz Capitulino [this message]
2009-06-15 22:41 ` [Qemu-devel] Re: [PATCH] readline: Remove unneeded qemu_mallocz() check Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615173731.026e9fa9@doriath \
--to=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).