qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] monitor: check for readline in monitor_event()
Date: Mon, 15 Jun 2009 17:38:58 -0300	[thread overview]
Message-ID: <20090615173858.31514f4f@doriath> (raw)


The call of readline_show_prompt() in CHR_EVENT_RESET's body will
trig a segfault if readline is not being used, because 'mon->rs'
will be NULL.

This fixes the problem by adding the proper check.

I've trigged this while playing with an off-tree code that disables
readline support, I'm not sure whether in-tree code can trig this.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/monitor.c b/monitor.c
index 6b45f6c..787101d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3002,7 +3002,7 @@ static void monitor_event(void *opaque, int event)
     case CHR_EVENT_RESET:
         monitor_printf(mon, "QEMU %s monitor - type 'help' for more "
                        "information\n", QEMU_VERSION);
-        if (mon->chr->focus == 0)
+        if (mon->rs && mon->chr->focus == 0)
             readline_show_prompt(mon->rs);
         break;
     }
-- 
1.6.3.GIT

             reply	other threads:[~2009-06-15 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 20:38 Luiz Capitulino [this message]
2009-06-15 22:42 ` [Qemu-devel] Re: monitor: check for readline in monitor_event() Jan Kiszka
2009-06-16 12:47   ` Luiz Capitulino
2009-06-16 15:46     ` Jan Kiszka
2009-06-16 16:04       ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090615173858.31514f4f@doriath \
    --to=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).