Re: [Qemu-devel] Register uhci_reset() callback.

[Gleb Natapov <gleb@redhat.com>]

On Mon, Jun 15, 2009 at 06:56:26PM +0100, Paul Brook wrote:
> > May be, but in this case after previous patch to reset interrupt level
> > for each device at PCI bridge level was rejected on the premise that
> > device should lower its own irq line on reset and since patches started
> > flowing in to do just that, I did not expect that eloquent explanation
> > would be needed for such trivial and obviously correct change.
> 
> This argument makes no sense. The fact that you'd recently submitted very 
> similar looking patches which either got rejected or need modification is a 
> good argument for providing an explanation. How else are we supposed to know 
> that you're not just making the same mistake again?
They was not even "similar looking". Have you followed the discussion
that those patches generated? Look at this commit and especially its commit
message: 32c86e95b. This commit is a direct result of the discussion
previous patches generated. Look at my patch now. Looks similar, no? So
people with commit permissions can follow lower standards that we mere
mortals?

--
			Gleb.