From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGYif-0005ci-P7
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 09:28:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGYib-0005cJ-88
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 09:28:57 -0400
Received: from [199.232.76.173] (port=37003 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGYib-0005cG-2M
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 09:28:53 -0400
Received: from verein.lst.de ([213.95.11.210]:60709)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MGYia-0004jp-Iw
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 09:28:52 -0400
Date: Tue, 16 Jun 2009 15:28:47 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20090616132847.GA7521@lst.de>
References: <1245158469-29498-1-git-send-email-avi@redhat.com>
	<1245158469-29498-2-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1245158469-29498-2-git-send-email-avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/2] raw-posix: open flags use BDRV_
	namespace, not posix namespace
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On Tue, Jun 16, 2009 at 04:21:08PM +0300, Avi Kivity wrote:
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 5032348..5790206 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -133,7 +133,7 @@ static int raw_open_common(BlockDriverState *bs, const char *filename,
>      s->lseek_err_cnt = 0;
>  
>      s->open_flags |= O_BINARY;
> -    if ((flags & BDRV_O_ACCESS) == O_RDWR) {
> +    if ((flags & BDRV_O_ACCESS) == BDRV_O_RDWR) {
>          s->open_flags |= O_RDWR;
>      } else {
>          s->open_flags |= O_RDONLY;

Looks good.