From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGcCH-0002pm-0Q for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:11:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGcCB-0002oe-Pf for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:11:44 -0400 Received: from [199.232.76.173] (port=41423 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGcCB-0002oX-JM for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:11:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39250) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGcCA-00031w-JG for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:11:39 -0400 Date: Tue, 16 Jun 2009 20:09:31 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] Register uhci_reset() callback. Message-ID: <20090616170931.GE782@redhat.com> References: <20090615170201.GA3964@redhat.com> <200906151856.28009.paul@codesourcery.com> <20090615181622.GA782@redhat.com> <20090615193054.GB782@redhat.com> <20090615200552.GC782@redhat.com> <20090616152050.GD782@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Avi Kivity , Paul Brook On Tue, Jun 16, 2009 at 07:54:25PM +0300, Blue Swirl wrote: > On 6/16/09, Gleb Natapov wrote: > > On Tue, Jun 16, 2009 at 06:14:51PM +0300, Blue Swirl wrote: > > > > Because interrupt line is stuck a guest can't get to the point where it > > > > loads a driver to the second device. For outside observer the guest > > > > just hangs. > > > > > > I see. The problem is in piix_pci interrupt handling, pci_irq_levels[] > > > should be set to zero on reset. > > > > The patch that does that was rejected earlier :) > > http://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00342.html > > http://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00344.html > > I think patch 2/3 is bogus, but 3/3 should be the correct way. Nobody > commented on that. > What is bogus about 2/3? But the comment were not about specific patch, more about the general approach. And conclusion was that each device should lower its line. This is how real HW works BTW. IMHO both things should be done, pci bus should reset its internal state and each device should lower its own line (bus implementation may be changed in the future to more be like real HW). -- Gleb.