From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGc5F-0000DN-3X for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:04:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGc5A-0000Bi-9Z for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:04:28 -0400 Received: from [199.232.76.173] (port=53063 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGc5A-0000BW-2Q for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:04:24 -0400 Received: from mx20.gnu.org ([199.232.41.8]:46762) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MGc59-0001lH-I2 for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:04:23 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGc58-0002Qy-P8 for qemu-devel@nongnu.org; Tue, 16 Jun 2009 13:04:23 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Register uhci_reset() callback. Date: Tue, 16 Jun 2009 18:04:20 +0100 References: <20090611084808.GA19508@redhat.com> <20090615193054.GB782@redhat.com> In-Reply-To: <20090615193054.GB782@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906161804.21107.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Avi Kivity , Gleb Natapov > > I find nothing wrong with your commit message (for completeness, it > > could mention that it installs a reset handler). > > It does in subject line. Subject line goes to log message with git-am. I consider this to be a bug in git - or at something you need to be aware of and avoid. IMHO the subject of an email should not contain critical information. Obviously it is important to give emails meaningful subject lines, but the body of the email should not require the reader to refer back to the subject. On pretty much every email client I've ever used the subject and other header information is displayed separately to the body of the email. Paul