From: Christoph Hellwig <hch@lst.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] Regression opening read-only cdroms
Date: Tue, 16 Jun 2009 23:16:42 +0200 [thread overview]
Message-ID: <20090616211642.GA28079@lst.de> (raw)
In-Reply-To: <f43fc5580906161137w34a1df78uf813cfa96aa2a66@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 148 bytes --]
Yes, explicitly passing the open flags is probably cleaner then
re-using the struct field. This passes my newly added test for
the open behaviour.
[-- Attachment #2: 0001-Fix-opening-of-read-only-raw-images.patch --]
[-- Type: application/x-patch, Size: 4031 bytes --]
prev parent reply other threads:[~2009-06-16 21:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 12:00 [Qemu-devel] Regression opening read-only cdroms Avi Kivity
2009-06-16 14:33 ` Jamie Lokier
2009-06-16 14:54 ` Stefano Stabellini
2009-06-16 14:54 ` Jamie Lokier
2009-06-16 16:28 ` Anthony Liguori
2009-06-16 17:14 ` Stefano Stabellini
2009-06-16 17:46 ` Jamie Lokier
2009-06-16 17:54 ` Avi Kivity
2009-06-16 18:56 ` Jamie Lokier
2009-06-16 19:02 ` Jamie Lokier
2009-06-16 21:11 ` Gerd Hoffmann
2009-06-17 6:27 ` Avi Kivity
2009-06-16 15:16 ` Avi Kivity
2009-06-16 15:54 ` Jamie Lokier
2009-06-16 16:17 ` Avi Kivity
2009-06-16 17:51 ` Jamie Lokier
2009-06-16 17:58 ` Avi Kivity
2009-06-18 12:37 ` Richard W.M. Jones
2009-06-24 20:23 ` Jamie Lokier
2009-06-24 22:43 ` Richard W.M. Jones
2009-06-25 0:50 ` Jamie Lokier
2009-06-25 8:17 ` Richard W.M. Jones
2009-06-16 16:28 ` Blue Swirl
2009-06-16 18:37 ` Blue Swirl
2009-06-16 21:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616211642.GA28079@lst.de \
--to=hch@lst.de \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).