From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGg32-0000ZQ-Bq for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:18:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGg2x-0000Vt-Ot for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:18:28 -0400 Received: from [199.232.76.173] (port=36812 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGg2x-0000Vj-GK for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:18:23 -0400 Received: from verein.lst.de ([213.95.11.210]:39266) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MGg2x-000330-2F for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:18:23 -0400 Date: Tue, 16 Jun 2009 23:18:19 +0200 From: Christoph Hellwig Message-ID: <20090616211819.GB28079@lst.de> References: <1245158469-29498-1-git-send-email-avi@redhat.com> <1245158469-29498-3-git-send-email-avi@redhat.com> <20090616132916.GB7521@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090616132916.GB7521@lst.de> Subject: [Qemu-devel] Re: [PATCH 2/2] raw-posix: Remove O_RDWR when attempting to open a file read-only List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, Christoph Hellwig On Tue, Jun 16, 2009 at 03:29:16PM +0200, Christoph Hellwig wrote: > Also looks good. Actually I think the variant from Blue Swirl is better as it gives us a clean state to start from.