From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sparc64: use pci_mem_base
Date: Wed, 17 Jun 2009 01:06:38 +0100 [thread overview]
Message-ID: <200906170106.39575.paul@codesourcery.com> (raw)
In-Reply-To: <b2fa41d60906161624x71f6447cya272f57a76738e64@mail.gmail.com>
On Wednesday 17 June 2009, Igor Kovalenko wrote:
> On Wed, Jun 17, 2009 at 3:13 AM, Paul Brook<paul@codesourcery.com> wrote:
> >> Fortunately there exists global pci_mem_base variable which
> >> is used by pci_to_cpu_addr() but it seems to be only called
> >> while clearing pci memory mapping.
> >
> > I think this is the wrong way to fix this. Better would be for the map
> > functions to go away altogether.
>
> Like pci bus would handle that memory address mapping between
> devices and cpu?
Yes. In fact individual devices generally shouldn't need to know about the
mappings at all. They should just provide a handler for accesses via a
particular BAR.
Paul
next prev parent reply other threads:[~2009-06-17 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 23:00 [Qemu-devel] [PATCH] sparc64: use pci_mem_base Igor Kovalenko
2009-06-16 23:13 ` Paul Brook
2009-06-16 23:24 ` Igor Kovalenko
2009-06-17 0:06 ` Paul Brook [this message]
2009-06-17 7:13 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906170106.39575.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).