From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGtUH-0006qN-5D
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:39:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGtUC-0006nK-EF
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:39:28 -0400
Received: from [199.232.76.173] (port=58992 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGtUC-0006mv-4f
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:39:24 -0400
Received: from mx2.redhat.com ([66.187.237.31]:56889)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1MGtUB-00021U-9J
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:39:23 -0400
Date: Wed, 17 Jun 2009 14:39:18 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Register usb-uhci reset function.
Message-ID: <20090617113918.GZ19508@redhat.com>
References: <20090616124702.GS19508@redhat.com>
	<5b31733c0906170207u1c553f6by67eb814644f55a10@mail.gmail.com>
	<20090617094318.GX19508@redhat.com>
	<5b31733c0906170317m67821bc0o74a656e1b7afef21@mail.gmail.com>
	<20090617110638.GY19508@redhat.com> <4A38D2A4.5070003@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A38D2A4.5070003@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dor Laor <dlaor@redhat.com>
Cc: Filip Navara <filip.navara@gmail.com>, qemu-devel@nongnu.org

On Wed, Jun 17, 2009 at 02:25:24PM +0300, Dor Laor wrote:
> Some general comments regarding this thread:
> Most pci devices register a reset handler and reset the irq line just  
> like this patch.
> I propose to accept this patch first, since it solves a real problem  
> (and not a theoretical one).
>
uhci not registering reset handler is clearly a bug and I hope everyone
agrees that this should be fixed. I think the main opposition is against
add qemu_irq() call to the reset handler. And if patch to piix3 is
applied then qemu_irq() in uhci reset handler can be dropped (it
shouldn't IMHO but whatever). The question is why maintainers who now argue
that reset function to piix3 is the beset thing since sliced bread haven't
applied the patch when it was posted?

--
			Gleb.