From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
Blue Swirl <blauwirbel@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mask table
Date: Wed, 17 Jun 2009 14:49:42 +0300 [thread overview]
Message-ID: <20090617114942.GB30859@redhat.com> (raw)
In-Reply-To: <4A38032D.5060506@us.ibm.com>
On Tue, Jun 16, 2009 at 03:40:13PM -0500, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> Change much of hw/pci to use symbolic constants and a table-driven
>> design: add a mask table with writable bits set and readonly bits unset.
>> Detect change by comparing original and new registers.
>>
>> This makes it easy to support capabilities where read-only/writeable
>> bit layout differs between devices, depending on capabilities present.
>>
>> As a result, writing a single byte in BAR registers now works as
>> it should. Writing to upper limit registers in the bridge
>> also works as it should. Code is also shorter.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> This series introduces warning (virtio_load decl/def does not match).
Seems to match and build cleanly with -Werror for me.
What warning do you see?
next prev parent reply other threads:[~2009-06-17 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1244635350.git.mst@redhat.com>
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 01/13] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-06-16 20:40 ` [Qemu-devel] " Anthony Liguori
2009-06-17 11:49 ` Michael S. Tsirkin [this message]
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 02/13] qemu: capability bits in pci save/restore Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 03/13] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 04/13] qemu: helper routines for pci access Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 05/13] qemu: MSI-X support functions Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 06/13] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 07/13] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] [PATCHv4 08/13] qemu: add support for resizing regions Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 09/13] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 10/13] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 11/13] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 12/13] qemu: virtio save/load bindings Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] [PATCHv4 13/13] qemu: add pci_get/set_byte Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617114942.GB30859@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).