From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGthH-0003Ji-MH
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:52:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGthD-0003Ar-2f
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:52:55 -0400
Received: from [199.232.76.173] (port=44930 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGthC-0003AX-UX
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:52:50 -0400
Received: from mx2.redhat.com ([66.187.237.31]:55030)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MGthC-00044h-CI
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 07:52:50 -0400
Date: Wed, 17 Jun 2009 14:49:42 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090617114942.GB30859@redhat.com>
References: <cover.1244635350.git.mst@redhat.com>
	<20090610122804.GB27174@redhat.com> <4A38032D.5060506@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A38032D.5060506@us.ibm.com>
Subject: [Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config
	use mask table
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>

On Tue, Jun 16, 2009 at 03:40:13PM -0500, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> Change much of hw/pci to use symbolic constants and a table-driven
>> design: add a mask table with writable bits set and readonly bits unset.
>> Detect change by comparing original and new registers.
>>
>> This makes it easy to support capabilities where read-only/writeable
>> bit layout differs between devices, depending on capabilities present.
>>
>> As a result, writing a single byte in BAR registers now works as
>> it should. Writing to upper limit registers in the bridge
>> also works as it should. Code is also shorter.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> This series introduces warning (virtio_load decl/def does not match).

Seems to match and build cleanly with -Werror for me.
What warning do you see?