* [Qemu-devel] PPC target
@ 2009-06-17 18:42 malc
2009-06-17 18:50 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: malc @ 2009-06-17 18:42 UTC (permalink / raw)
To: qemu-devel
I don't know what exactly changed (-Werror, opcode section removal, compiler
version), but PPC target doesn't build here without:
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index f60f99a..4044eee 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -759,7 +759,7 @@ static always_inline void gen_op_arith_compute_ca(DisasContext *ctx, TCGv arg1,
static always_inline void gen_op_arith_add(DisasContext *ctx, TCGv ret, TCGv arg1, TCGv arg2,
int add_ca, int compute_ca, int compute_ov)
{
- TCGv t0, t1;
+ TCGv t0, t1 = t1;
if ((!compute_ca && !compute_ov) ||
(!TCGV_EQUAL(ret,arg1) && !TCGV_EQUAL(ret, arg2))) {
@@ -1176,7 +1176,7 @@ static void gen_nego(DisasContext *ctx)
static always_inline void gen_op_arith_subf(DisasContext *ctx, TCGv ret, TCGv arg1, TCGv arg2,
int add_ca, int compute_ca, int compute_ov)
{
- TCGv t0, t1;
+ TCGv t0, t1 = t1;
if ((!compute_ca && !compute_ov) ||
(!TCGV_EQUAL(ret, arg1) && !TCGV_EQUAL(ret, arg2))) {
@@ -3355,7 +3355,7 @@ static always_inline void gen_bcond (DisasContext *ctx, int type)
{
uint32_t bo = BO(ctx->opcode);
int l1 = gen_new_label();
- TCGv target;
+ TCGv target = target;
ctx->exception = POWERPC_EXCP_BRANCH;
if (type == BCOND_LR || type == BCOND_CTR) {
--
mailto:av1474@comtv.ru
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] PPC target
2009-06-17 18:42 [Qemu-devel] PPC target malc
@ 2009-06-17 18:50 ` Blue Swirl
2009-06-17 19:16 ` malc
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2009-06-17 18:50 UTC (permalink / raw)
To: malc; +Cc: qemu-devel
On 6/17/09, malc <av1474@comtv.ru> wrote:
>
> I don't know what exactly changed (-Werror, opcode section removal, compiler
> version), but PPC target doesn't build here without:
>
What's the problem? Error from compiler?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] PPC target
2009-06-17 18:50 ` Blue Swirl
@ 2009-06-17 19:16 ` malc
2009-06-18 15:37 ` Paul Brook
0 siblings, 1 reply; 4+ messages in thread
From: malc @ 2009-06-17 19:16 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
On Wed, 17 Jun 2009, Blue Swirl wrote:
> On 6/17/09, malc <av1474@comtv.ru> wrote:
> >
> > I don't know what exactly changed (-Werror, opcode section removal, compiler
> > version), but PPC target doesn't build here without:
> >
>
> What's the problem? Error from compiler?
Same old, variable might be uninitialized.
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] PPC target
2009-06-17 19:16 ` malc
@ 2009-06-18 15:37 ` Paul Brook
0 siblings, 0 replies; 4+ messages in thread
From: Paul Brook @ 2009-06-18 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl
On Wednesday 17 June 2009, malc wrote:
> On Wed, 17 Jun 2009, Blue Swirl wrote:
> > On 6/17/09, malc <av1474@comtv.ru> wrote:
> > > I don't know what exactly changed (-Werror, opcode section removal,
> > > compiler version), but PPC target doesn't build here without:
> >
> > What's the problem? Error from compiler?
>
> Same old, variable might be uninitialized.
In that case you should be using TCGV_UNUSED.
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-18 15:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-17 18:42 [Qemu-devel] PPC target malc
2009-06-17 18:50 ` Blue Swirl
2009-06-17 19:16 ` malc
2009-06-18 15:37 ` Paul Brook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).