From: Jamie Lokier <jamie@shareable.org>
To: "François Revol" <revol@free.fr>
Cc: programmingkidx@gmail.com, Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
Date: Sun, 21 Jun 2009 00:25:08 +0100 [thread overview]
Message-ID: <20090620232508.GA29958@shareable.org> (raw)
In-Reply-To: <10665282192-BeMail@laptop>
François Revol wrote:
> > On 06/20/2009 05:31 PM, Anthony Liguori wrote:
> > > Please include a Signed-off-by line and use C-style comments
> > > instead
> > > of C++ style comments. Otherwise, looks good.
> >
> > What do we have against C++ style comments?
>
> They are not valid in C code :P
Wrong.
Valid in GNU C for about 14 years, and ANSI/ISO C for about 10 years...
I'll be surprised if any C compiler used on any open source operating
system, or any major commercial C compiler, doesn't accept them.
Of course I still forbid them in my code too - they look wrong :-)
-- Jamie
next prev parent reply other threads:[~2009-06-20 23:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 2:22 [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC m a
2009-06-20 14:31 ` Anthony Liguori
2009-06-20 18:59 ` Avi Kivity
2009-06-20 19:03 ` François Revol
2009-06-20 19:15 ` Avi Kivity
2009-06-20 23:25 ` Jamie Lokier [this message]
2009-06-21 10:01 ` Andreas Färber
2009-06-24 18:25 ` Jamie Lokier
2009-06-24 18:54 ` Andreas Färber
2009-06-24 18:59 ` Filip Navara
2009-06-24 19:08 ` Jamie Lokier
2009-06-20 20:46 ` Anthony Liguori
2009-06-21 9:01 ` Avi Kivity
2009-06-20 19:16 ` Christoph Hellwig
2009-06-20 23:30 ` Jamie Lokier
2009-06-20 23:37 ` Anthony Liguori
2009-06-21 0:41 ` G 3
2009-06-24 18:27 ` Jamie Lokier
2009-06-21 0:46 ` G 3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090620232508.GA29958@shareable.org \
--to=jamie@shareable.org \
--cc=avi@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).