From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MI9w4-000167-GD for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:25:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MI9vz-00012N-3L for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:25:23 -0400 Received: from [199.232.76.173] (port=37838 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MI9vy-00011Y-NA for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:25:18 -0400 Received: from mail2.shareable.org ([80.68.89.115]:48765) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MI9vu-0004ah-V0 for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:25:15 -0400 Date: Sun, 21 Jun 2009 00:25:08 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC Message-ID: <20090620232508.GA29958@shareable.org> References: <4A3D3189.1080307@redhat.com> <10665282192-BeMail@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <10665282192-BeMail@laptop> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Fran=E7ois?= Revol Cc: programmingkidx@gmail.com, Avi Kivity , qemu-devel@nongnu.org François Revol wrote: > > On 06/20/2009 05:31 PM, Anthony Liguori wrote: > > > Please include a Signed-off-by line and use C-style comments > > > instead > > > of C++ style comments. Otherwise, looks good. > > > > What do we have against C++ style comments? > > They are not valid in C code :P Wrong. Valid in GNU C for about 14 years, and ANSI/ISO C for about 10 years... I'll be surprised if any C compiler used on any open source operating system, or any major commercial C compiler, doesn't accept them. Of course I still forbid them in my code too - they look wrong :-) -- Jamie