From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ71m-0003db-PJ for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:31:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ71i-0003ZE-1x for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:31:14 -0400 Received: from [199.232.76.173] (port=35509 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ71h-0003Z3-O9 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:31:09 -0400 Received: from verein.lst.de ([213.95.11.210]:52795) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MJ71h-0007Qd-8W for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:31:09 -0400 Date: Tue, 23 Jun 2009 16:31:05 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] the qemu-iotests test suite is now available Message-ID: <20090623143105.GA17748@lst.de> References: <20090622210523.GA8024@lst.de> <4A409D65.3040104@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A409D65.3040104@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christoph Hellwig , qemu-devel@nongnu.org On Tue, Jun 23, 2009 at 11:16:21AM +0200, Kevin Wolf wrote: > About the qcow2 tests there is one thing to note: These test cases use > hard coded offsets which were calculated for 4k clusters. For 64k > clusters (which the default now) I'm almost sure they don't test the > critical points any more. So we'll need to change offsets dynamically > depending on the cluster size of the qcow2 image. Or just run the test for all interesting cluster sizes to some more coverage (should be only 4k and 64k for now).