From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ81e-0006Pk-D8 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:35:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ81c-0006MU-PA for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:35:09 -0400 Received: from [199.232.76.173] (port=56191 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ81c-0006LU-Fn for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:35:08 -0400 Received: from mx20.gnu.org ([199.232.41.8]:14892) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJ81b-0004zg-VA for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:35:08 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ81a-0006BH-Qg for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:35:07 -0400 Date: Tue, 23 Jun 2009 08:35:05 -0700 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH] gdb-xml: fix hacks in powerpc register numbering Message-ID: <20090623153505.GK1119@codesourcery.com> References: <1244167348-806-1-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1244167348-806-1-git-send-email-froydnj@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jun 04, 2009 at 07:02:28PM -0700, Nathan Froyd wrote: > The powerpc xml files contained a hack--an empty, non-existent > register--for getting the register numbers to line up for > newer (XML-aware) and older (non-XML-aware) GDB. While this hack worked > in some cases, it didn't work in all cases, notably when the user used > `finish' or `continue': GDB would attempt to read the non-existent > register and QEMU would complain. > > This patch fixes things up properly. Instead of inserting a fake > register, we explicitly declare the floating-point and SPE registers to > start at 71. This action accomplishes the same thing as the nasty hack, > except that now GDB never tries to fetch the non-existant register 70. Ping. It would be nice to get this in prior to the stable 0.11.0 release. -Nathan